Quest2 phase4 todo checklist #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonypetersen
approved these changes
Dec 6, 2024
|
@anthonypetersen Thanks for the huge review! I just pushed a small change for JAWS focus handling refinements if you can take a quick look. Here's the commit: 3309d99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a list of updates:
•Tested tables and fieldsets with response handling.
•Added
<legend>handling for accessibility (optimized question reading process).•Implemented errorLogger for pass-through error reporting to parent app.
•Handled mobile tables: double reading of text.
•Handled initializeActiveQuestionState conflicting with store()
•Ensured backwards compatibility with Quest properties
•Handled SOCcer, loading of async questions, and return to survey on async question
•Adapted progress bar to an optional internal feature
•Handled store() response value and reverting question on error
•Temp handled
RCRTUP_YOB_V1R0variable (now 'yob')•Tested grids incl MRE survey grids
•Handled remaining .document access issues from state manager conversion
•Tested state values on reload -> save operation (it was resetting activeState. Fixed)
•Updated button alignment in survey
•Simplified Grid mobile device CSS (card view)
•Refined loop handling incl return to survey mid-loop
•renamed
replace2.js->main.js•Misc cleanups, refactoring (some accessibility functions, some events, and evaluateCondition for separation of concerns), and TODO items
•Completed VoiceOver testing
•Resolved bug in Address entry -> LAW survey. (forid properties and DOM updates when going back and forth on a question)
TODO in upcoming PR:
•JAWS testing
•Implement debug logging to match original Quest (renderer only).